[webkit-reviews] review denied: [Bug 80110] [Forms] HTMLFieldSetElement.idl doesn't have elements attribute. : [Attachment 143262] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 22 21:44:07 PDT 2012
Kent Tamura <tkent at chromium.org> has denied Rakesh <rakesh.kn at motorola.com>'s
request for review:
Bug 80110: [Forms] HTMLFieldSetElement.idl doesn't have elements attribute.
https://bugs.webkit.org/show_bug.cgi?id=80110
Attachment 143262: proposed patch
https://bugs.webkit.org/attachment.cgi?id=143262&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143262&action=review
> Source/WebCore/html/HTMLFieldSetElement.cpp:96
> + uint64_t docversion = document()->domTreeVersion();
should be docVersion, documentVersion, or domTreeVersion.
> Source/WebCore/html/HTMLFieldSetElement.cpp:105
> + for (Element* node = firstElementChild(); node; node =
node->nextElementSibling()) {
We need a test to confirm that fieldset.elements contains listed-elements in
deeper places like
<fieldset>
<div>
<input>
</div>
</fieldset>
> Source/WebCore/html/HTMLFieldSetElement.cpp:117
> + if (node->hasTagName(imgTag)) {
> + m_imageElements.append(static_cast<HTMLImageElement*>(node));
> + continue;
> + }
Why do you need to collect img elements?
> Source/WebCore/html/HTMLFieldSetElement.cpp:129
> +const Vector<HTMLImageElement*>& HTMLFieldSetElement::imageElements() const
ditto.
> Source/WebCore/html/HTMLFieldSetElement.h:45
> + const Vector<HTMLImageElement*>& imageElements() const;
ditto.
> Source/WebCore/html/HTMLFieldSetElement.h:65
> + mutable Vector<HTMLImageElement*> m_imageElements;
ditto.
> Source/WebCore/html/HTMLFieldSetElement.idl:29
>
> + readonly attribute HTMLCollection elements;
> +
> readonly attribute DOMString type;
Please put 'elements' after 'type' in order to follow the IDL in the
specification.
> Source/WebCore/html/RadioNodeList.cpp:87
> + return equalIgnoringCase(testElement->getIdAttribute(), m_name) ||
equalIgnoringCase(testElement->getNameAttribute(), m_name);
This is not a new code, but equalIgnoringCase() looks wrong. ID matching and
name matching should be case-sensitive.
More information about the webkit-reviews
mailing list