[webkit-reviews] review granted: [Bug 84195] [chromium] Improve W3C conformance of backface visibility : [Attachment 143082] PaUpdate to patch due to r117645

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 22 16:57:01 PDT 2012


Adrienne Walker <enne at google.com> has granted Shawn Singh
<shawnsingh at chromium.org>'s request for review:
Bug 84195: [chromium] Improve W3C conformance of backface visibility
https://bugs.webkit.org/show_bug.cgi?id=84195

Attachment 143082: PaUpdate to patch due to r117645
https://bugs.webkit.org/attachment.cgi?id=143082&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=143082&action=review


R=me.  I love all the comments and named functions in CCLayerTreeHostCommon. 
Thanks for all the tests and for taking the time to make the rectangles in the
layout tests axis aligned.

> Source/WebCore/ChangeLog:3
> +	   [chromium] Improve W3C conformance of backface-visibility

I know that all the code changes are Chromium-specific, but if these new tests
fail on any other platform it might be unexpected to see them in a [chromium]
change.  So, I'd prefer that you land this whole patch without the [chromium]
tag.


More information about the webkit-reviews mailing list