[webkit-reviews] review granted: [Bug 82287] MemoryCache should adopt our standard RefCounted model for object lifetime : [Attachment 143386] Make all the bots happy

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 22 16:06:10 PDT 2012


Eric Seidel <eric at webkit.org> has granted Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 82287: MemoryCache should adopt our standard RefCounted model for object
lifetime
https://bugs.webkit.org/show_bug.cgi?id=82287

Attachment 143386: Make all the bots happy
https://bugs.webkit.org/attachment.cgi?id=143386&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
LGTM.  Please add some explanation to the top of CachedResource.h as well as
CachedResourceHandle.h to explain when one is supposed to use a
CachedResourceHandle, vs. a RefPtr.  You can do that in a separate patch, but I
believe it's important to document this distinction in the code now that it's
possible to confuse these two.


More information about the webkit-reviews mailing list