[webkit-reviews] review granted: [Bug 87169] Move some CSS regions properties to CSSParser::isValidKeywordPropertyAndValue. : [Attachment 143365] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Alexis Menard (darktears)
<alexis.menard at openbossa.org>'s request for review:
Bug 87169: Move some CSS regions properties to
CSSParser::isValidKeywordPropertyAndValue.
https://bugs.webkit.org/show_bug.cgi?id=87169

Attachment 143365: Patch
https://bugs.webkit.org/attachment.cgi?id=143365&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143365&action=review


OK

> Source/WebCore/css/CSSParser.cpp:588
> +    case CSSPropertyWebkitColumnBreakBefore:
> +    case CSSPropertyWebkitRegionBreakAfter:
> +    case CSSPropertyWebkitRegionBreakBefore:
> +	   if (valueID == CSSValueAuto || valueID == CSSValueAlways || valueID
== CSSValueAvoid || valueID == CSSValueLeft || valueID == CSSValueRight)
> +	       return ((propertyId == CSSPropertyWebkitRegionBreakAfter) ||
(propertyId == CSSPropertyWebkitRegionBreakBefore)) ?
parserContext.isCSSRegionsEnabled : true;

Should we split the region properties into a separate part of the switch
statement?  It would avoid the extra check for the non-region properties.