[webkit-reviews] review granted: [Bug 87080] Use the same animation begin time while updating compositing layers : [Attachment 143356] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 87080: Use the same animation begin time while updating compositing layers
https://bugs.webkit.org/show_bug.cgi?id=87080

Attachment 143356: Patch
https://bugs.webkit.org/attachment.cgi?id=143356&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=143356&action=review


> Source/WebCore/ChangeLog:26
> +	   to cover over calls to recalcStyle which might need this (87159).

over-calls?

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1325
> +	   AnimationUpdateBlock animationBlock(renderer->animation());

I like animationUpdateBlock as the var names through the patch, but not a big
deal.

> Source/WebCore/rendering/RenderLayerCompositor.cpp:354
> +    Frame* frame = m_renderView->frameView()->frame();
> +    AnimationUpdateBlock animationBlock(frame->animation());

One line? no need for frame elsewhere?