[webkit-reviews] review granted: [Bug 87128] [chromium] add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries : [Attachment 143335] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted jochen at chromium.org's request
for review:
Bug 87128: [chromium] add --driver-name option to run_webkit_tests.py to allow
for selecting alternative DRT binaries
https://bugs.webkit.org/show_bug.cgi?id=87128

Attachment 143335: Patch
https://bugs.webkit.org/attachment.cgi?id=143335&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143335&action=review


> Tools/Scripts/webkitpy/layout_tests/port/chromium.py:122
> +	   return self.get_option('driver_name', 'DumpRenderTree')

Sorry I missed this before ... this should actually either be implemented in
base.py or we should have a "virtual" base method in base.py that raises
NotImplementedError.