[webkit-reviews] review granted: [Bug 85118] REGRESSION(r95249): Iframes are printed blank : [Attachment 143114] Iframe printing fix.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Vitaly Buka
<vitalybuka at chromium.org>'s request for review:
Bug 85118: REGRESSION(r95249): Iframes are printed blank
https://bugs.webkit.org/show_bug.cgi?id=85118

Attachment 143114: Iframe printing fix.
https://bugs.webkit.org/attachment.cgi?id=143114&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=143114&action=review


> Source/WebCore/ChangeLog:24
> +	   (WebCore):

Please remove non-helpful lines like this from ChangeLog.

> Source/WebCore/ChangeLog:29
> +	   (RenderView):

And lines like this.

>> Source/WebCore/page/Frame.cpp:529
>>	    view()->forceLayout();
> 
> Just for clarification. For subframes we fall back to view()->forceLayout();
which is almost the same as view()->forceLayoutForPagination but without
pagesize restrictions.

If that clarification is needed, then it should probably be in a comment in the
code, not just a comment during patch review.