[webkit-reviews] review granted: [Bug 87062] [TextureMapper] [Cairo] Implement repaint counters : [Attachment 143160] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 87062: [TextureMapper] [Cairo] Implement repaint counters
https://bugs.webkit.org/show_bug.cgi?id=87062

Attachment 143160: Patch
https://bugs.webkit.org/attachment.cgi?id=143160&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143160&action=review


I'm just not sure about the border color, feels like you may want to have a
border distinct from the background, but I guess it'll look readable like this
anyway.

>> Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp:573
>> +#if USE(CAIRO)
> 
> This would be more readable inside the function.

Hmm, I think it would be less readable with different implementations taking
the whole function body. As it is now it's pretty obvious that each
implementation has a completely different implementation.