[webkit-reviews] review granted: [Bug 84650] FormData.append() should throw TypeError for not enough arguments : [Attachment 143259] rebased patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 22 10:02:11 PDT 2012


Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 84650: FormData.append() should throw TypeError for not enough arguments
https://bugs.webkit.org/show_bug.cgi?id=84650

Attachment 143259: rebased patch
https://bugs.webkit.org/attachment.cgi?id=143259&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Since Sam wrote that comment in the other bug, we've changed our default
behavior to throwing exception when web sites supply too few arguments.  Given
that we're already throwing in this case in V8 and Firefox throws, this patch
seems relatively safe from a web compatibly point of view.  You might want to
give Sam a chance to comment before landing.

(I would also add the information about what other browsers do to the ChangeLog
in case we look into the history of this behavior later.)


More information about the webkit-reviews mailing list