[webkit-reviews] review denied: [Bug 87128] [chromium] add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries : [Attachment 143294] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 22 09:59:01 PDT 2012


Dirk Pranke <dpranke at chromium.org> has denied jochen at chromium.org's request for
review:
Bug 87128: [chromium] add --driver-name option to run_webkit_tests.py to allow
for selecting alternative DRT binaries
https://bugs.webkit.org/show_bug.cgi?id=87128

Attachment 143294: Patch
https://bugs.webkit.org/attachment.cgi?id=143294&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
We should probably have at least one test for this ... I'd add something to
run_webkit_tests_integrationtest.py to ensure that the command line arg has the
right effect.

What's the long-term vision for running both DRT and ContentShell? Will we need
two different "port"s? Do we need to set up additional bots?


More information about the webkit-reviews mailing list