[webkit-reviews] review granted: [Bug 87063] <shadow> and <content> should be hidden behind ContextEnabledFeatures : [Attachment 143240] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Hajime Morrita
<morrita at google.com>'s request for review:
Bug 87063: <shadow> and <content> should be hidden behind
ContextEnabledFeatures
https://bugs.webkit.org/show_bug.cgi?id=87063

Attachment 143240: Patch
https://bugs.webkit.org/attachment.cgi?id=143240&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143240&action=review


> Source/WebCore/ChangeLog:6
> +	   This change repalced "runtimeConditional" tag definition property

repalced -> replaces.

> Source/WebCore/ChangeLog:8
> +	   ContextEnabledFeatures instead of RuntimeEnabledFeatures.

But why are we replacing this? Should not both of these co-exist?

> Source/WebCore/ChangeLog:9
> +	   This also introduce
ContextEnabledFeatures::shadowDOMEnabled(Document*)

introduce -> introduces.

> Source/WebCore/ChangeLog:10
> +	   for a complement.

"as a complement". But why do we need both?