[webkit-reviews] review denied: [Bug 40362] [Qt] canvas/philip/tests/2d.path.stroke.overlap.html fails with Qt-4.6.2 or higher : [Attachment 143148] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 22 09:08:51 PDT 2012
Noam Rosenthal <noam.rosenthal at nokia.com> has denied Rafael Brandao
<rafael.lobo at openbossa.org>'s request for review:
Bug 40362: [Qt] canvas/philip/tests/2d.path.stroke.overlap.html fails with
Qt-4.6.2 or higher
https://bugs.webkit.org/show_bug.cgi?id=40362
Attachment 143148: Patch
https://bugs.webkit.org/attachment.cgi?id=143148&action=review
------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=143148&action=review
> Source/WebCore/platform/graphics/qt/GraphicsContextQt.cpp:575
> + QPainterPath stroke = pathStroker.createStroke(platformPath);
> + p->fillPath(stroke, shadowPen.brush());
You repeat this sequence about 5 times, please put it in some static function.
More information about the webkit-reviews
mailing list