[webkit-reviews] review requested: [Bug 78444] [Qt] Middle clicking a scrollbar causes text to be pasted. : [Attachment 143305] Patch with fix and improved layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 22 08:26:48 PDT 2012


Steffen Imhof <steffen.imhof at basyskom.com> has asked  for review:
Bug 78444: [Qt] Middle clicking a scrollbar causes text to be pasted.
https://bugs.webkit.org/show_bug.cgi?id=78444

Attachment 143305: Patch with fix and improved layout test
https://bugs.webkit.org/attachment.cgi?id=143305&action=review

------- Additional Comments from Steffen Imhof <steffen.imhof at basyskom.com>
I had a look into this and think that the clipboard handling should simply not
be executed when the event was already handled. When checking how to make a
layout test for this, I stumbled upon an existing one. But this was a PASS all
the time (at least for the Qt version). So I changed the test to be a bit more
like the use case described in this bug (using an <input> field). Now it
correctly switches from FAIL to PASS when the change in qwebpage.cpp is
applied.


More information about the webkit-reviews mailing list