[webkit-reviews] review granted: [Bug 85956] [EFL] EFL's DRT does not print didFailProvisionalLoadWithError messages : [Attachment 141097] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 22 07:59:01 PDT 2012


Gustavo Noronha (kov) <gns at gnome.org> has granted Christophe Dumez
<christophe.dumez at intel.com>'s request for review:
Bug 85956: [EFL] EFL's DRT does not print didFailProvisionalLoadWithError
messages
https://bugs.webkit.org/show_bug.cgi?id=85956

Attachment 141097: Patch
https://bugs.webkit.org/attachment.cgi?id=141097&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141097&action=review


cq- because of the nit

> Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp:583
> +    // signals. m_provisionalLoadFailedFrame is used to avoid printing twice
the load error in

Adding a colon after 'error' here would make this clearer I believe.


More information about the webkit-reviews mailing list