[webkit-reviews] review granted: [Bug 87120] Web Inspector: annotate InjectedScriptSource.js for closure compiler : [Attachment 143284] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 22 05:47:13 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 87120: Web Inspector: annotate InjectedScriptSource.js for closure compiler
https://bugs.webkit.org/show_bug.cgi?id=87120

Attachment 143284: Patch
https://bugs.webkit.org/attachment.cgi?id=143284&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143284&action=review


> Source/WebCore/inspector/InjectedScriptExterns.js:40
> +InjectedScriptHost.prototype.storageId = function(object) {}

{ }

> Source/WebCore/inspector/compile-injected-script.sh:32
> +java -jar ~/closure/compiler.jar\

could you merge it with the main compiler script instead?


More information about the webkit-reviews mailing list