[webkit-reviews] review granted: [Bug 87107] Web Inspector: HeapProfiler: upstream retainedSize calculation. : [Attachment 143248] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 87107: Web Inspector: HeapProfiler: upstream retainedSize calculation.
https://bugs.webkit.org/show_bug.cgi?id=87107

Attachment 143248: Patch
https://bugs.webkit.org/attachment.cgi?id=143248&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143248&action=review


> Source/WebCore/inspector/front-end/HeapSnapshot.js:1270
> +	       var nodeSelfSize = nodes[nodeOrdinal * nodeFieldCount +
nodeSelfSizeOffset];

You can introduce a var for nodeSelfSizeIndex and use an increment to keep it
up to date.

> Source/WebCore/inspector/front-end/HeapSnapshot.js:1276
> +	       } while (currentNodeOrdinal !== prevNodeOrdinal);

while (currentNodeOrdinal) would work as well as the root index is 0.