[webkit-reviews] review granted: [Bug 87098] Web Inspector: allow showing selected object in another heap profiler view : [Attachment 143238] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 22 02:45:53 PDT 2012
Vsevolod Vlasov <vsevik at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 87098: Web Inspector: allow showing selected object in another heap
profiler view
https://bugs.webkit.org/show_bug.cgi?id=87098
Attachment 143238: Patch
https://bugs.webkit.org/attachment.cgi?id=143238&action=review
------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143238&action=review
> Source/WebCore/inspector/front-end/HeapSnapshotDataGrids.js:51
> + this.addEventListener("sorting complete", this._sortingComplete, this);
This event is not used anywhere but in this class, could you replace it with a
private method instead?
More information about the webkit-reviews
mailing list