[webkit-reviews] review denied: [Bug 87078] Make CSSParser::filteredProperties() O(n) instead of O(n^2) and improve readability. : [Attachment 143188] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 22 01:10:22 PDT 2012


Antti Koivisto <koivisto at iki.fi> has denied Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 87078: Make CSSParser::filteredProperties() O(n) instead of O(n^2) and
improve readability.
https://bugs.webkit.org/show_bug.cgi?id=87078

Attachment 143188: Patch
https://bugs.webkit.org/attachment.cgi?id=143188&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
I don't see the point. Duplicate properties are rare. You add two extra
iterations (loop and reversal) to the common case.


More information about the webkit-reviews mailing list