[webkit-reviews] review granted: [Bug 87077] [Forms][Meter][Progress] Change function signature of parseToDoubleForNumberType : [Attachment 143191] Patch 1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 22 00:07:47 PDT 2012
Hajime Morrita <morrita at google.com> has granted yosin at chromium.org's request
for review:
Bug 87077: [Forms][Meter][Progress] Change function signature of
parseToDoubleForNumberType
https://bugs.webkit.org/show_bug.cgi?id=87077
Attachment 143191: Patch 1
https://bugs.webkit.org/attachment.cgi?id=143191&action=review
------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=143191&action=review
> Source/WebCore/html/parser/HTMLParserIdioms.h:48
> +double parseToDoubleForNumberType(const String&, double);
It's worth giving a parameter name since the intention isn't clear for this
case.
> Source/WebCore/html/parser/HTMLParserIdioms.h:50
> +double parseToDoubleForNumberTypeWithDecimalPlaces(const String&, unsigned*,
double);
Ditto.
More information about the webkit-reviews
mailing list