[webkit-reviews] review granted: [Bug 87083] [V8] setDOMException() should return v8::Handle<v8::Value>() : [Attachment 143195] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 21 23:53:22 PDT 2012
Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 87083: [V8] setDOMException() should return v8::Handle<v8::Value>()
https://bugs.webkit.org/show_bug.cgi?id=87083
Attachment 143195: Patch
https://bugs.webkit.org/attachment.cgi?id=143195&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143195&action=review
> Source/WebCore/bindings/v8/V8Proxy.cpp:592
> - return;
> + return v8::Handle<v8::Value>();
Should we return v8::Local<v8::Value> ? I guess it doesn't matter for empty
handles.
More information about the webkit-reviews
mailing list