[webkit-reviews] review granted: [Bug 63365] ASSERTs in RenderInline::layout() : [Attachment 143064] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Rob Buis
<rwlbuis at gmail.com>'s request for review:
Bug 63365: ASSERTs in RenderInline::layout()
https://bugs.webkit.org/show_bug.cgi?id=63365

Attachment 143064: Patch
https://bugs.webkit.org/attachment.cgi?id=143064&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143064&action=review


r=me.

> Source/WebCore/svg/SVGElement.cpp:499
> +	   if (childContext.node()->hasTagName(SVGNames::textPathTag)

We might want to think about adding a static HashSet<QName> of allowed tags
here, and check against that.
childShouldCreateRenderer() is used quite often. Not sure if its worth it
though.