[webkit-reviews] review denied: [Bug 86723] Web Inspector: filter out debugging stuff from the heap class view : [Attachment 143049] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 21 23:23:56 PDT 2012
Yury Semikhatsky <yurys at chromium.org> has denied Alexei Filippov
<alexeif at chromium.org>'s request for review:
Bug 86723: Web Inspector: filter out debugging stuff from the heap class view
https://bugs.webkit.org/show_bug.cgi?id=86723
Attachment 143049: Patch
https://bugs.webkit.org/attachment.cgi?id=143049&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143049&action=review
r- for the failing tests.
> Source/WebCore/ChangeLog:6
> + Reviewed by NOBODY (OOPS!).
Please describe here what the change is about.
> Source/WebCore/inspector/front-end/HeapSnapshot.js:866
> + var masterFilter = function(node) {
style: var masterFilter = function(node) { -> function masterFilter(node)
>
LayoutTests/inspector/profiler/heap-snapshot-comparison-dom-groups-change.html:
57
> + edge_types: [["shortcut"], "", ""]
Why did this change?
> LayoutTests/inspector/profiler/heap-snapshot-test.js:402
> + nodes.push(0, 0, 1, 0, (sizeOfA + sizeOfB) * instanceCount, 0,
addEdge(1, 1, null));
You can use the new mock snapshot builder to construct the raw snapshot. Ilya
added it yesterday.
More information about the webkit-reviews
mailing list