[webkit-reviews] review denied: [Bug 86844] Web Inspector: "Deactivate All Breapoints" should visually get reflected in Breakpoints pane. : [Attachment 143185] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 21 22:55:11 PDT 2012


Pavel Feldman <pfeldman at chromium.org> has denied sam <dsam2912 at gmail.com>'s
request for review:
Bug 86844: Web Inspector: "Deactivate All Breapoints" should visually get
reflected in Breakpoints pane.
https://bugs.webkit.org/show_bug.cgi?id=86844

Attachment 143185: Patch
https://bugs.webkit.org/attachment.cgi?id=143185&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143185&action=review


r- for a tiny error, then it is good to go.

> Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js:181
> +	   contextMenu.appendItem(breakpointActivationTitle,
toggleActiveStateForBreakpoints.bind()); 

You should either bind(this) or not bind at all. In this case, you don't need
to bind since you don't access this in the toggle function. You could also do:

var breakpointActive = WebInspector.debuggerModel.breakpointsActive();
var title = WebInspector.UIString(breakpointActive ? "Deactivate All
Breakpoints" : "Activate All Breakpoints");
contextMenu.appendItem(title,
WebInspector.debuggerModel.setBreakpointsActive.bind(WebInspector.debuggerModel
, !breakpointActive));


More information about the webkit-reviews mailing list