[webkit-reviews] review denied: [Bug 86958] [WebSocket] WebSocket object should fire a simple event named error when it is required to fail the websocket connection. : [Attachment 142903] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 21 22:45:17 PDT 2012


Yuta Kitamura <yutak at chromium.org> has denied Li Yin <li.yin at intel.com>'s
request for review:
Bug 86958: [WebSocket] WebSocket object should fire a simple event named error
when it is required to fail the websocket connection.
https://bugs.webkit.org/show_bug.cgi?id=86958

Attachment 142903: Patch
https://bugs.webkit.org/attachment.cgi?id=142903&action=review

------- Additional Comments from Yuta Kitamura <yutak at chromium.org>
r- because adding a new callback fireErrorEvent() is clearly unacceptable.
fireErrorEvent() doesn't work properly in Web Workers, as the definition for
workers isn't provided.


More information about the webkit-reviews mailing list