[webkit-reviews] review granted: [Bug 86991] REGRESSION r110315: [V8] Event handler throws TypeError for an input element with name="arguments" : [Attachment 143167] patch for landing
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 21 18:52:38 PDT 2012
Erik Arvidsson <arv at chromium.org> has granted review:
Bug 86991: REGRESSION r110315: [V8] Event handler throws TypeError for an input
element with name="arguments"
https://bugs.webkit.org/show_bug.cgi?id=86991
Attachment 143167: patch for landing
https://bugs.webkit.org/attachment.cgi?id=143167&action=review
------- Additional Comments from Erik Arvidsson <arv at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143167&action=review
Looks good to me
> Source/WebCore/bindings/v8/V8LazyEventListener.cpp:154
> + code.append("\n};}}}};");
> + code.append("return arguments[3]();})");
I would have done
code.append("\n};}}}};" \
"return arguments[3]();})");
but it doesn't matter
More information about the webkit-reviews
mailing list