[webkit-reviews] review denied: [Bug 87031] DomStorage events handling needs TLC (3) : [Attachment 143122] lessChatty

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 21 18:03:09 PDT 2012


Adam Barth <abarth at webkit.org> has denied Michael Nordman
<michaeln at google.com>'s request for review:
Bug 87031: DomStorage events handling needs TLC (3)
https://bugs.webkit.org/show_bug.cgi?id=87031

Attachment 143122: lessChatty
https://bugs.webkit.org/attachment.cgi?id=143122&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
The general idea of this patch is fine.  The only wonky part is
didAddStorageEventListener being conditional on PLATFORM(CHROMIUM).  It's also
a pretty subtle change that's likely to be broken if we don't add a test
upstream that checks that we continue to do this correctly.


More information about the webkit-reviews mailing list