[webkit-reviews] review granted: [Bug 86916] garden-o-matic should not fetch from debug bots if it also knows about the release bots : [Attachment 143146] post a block of json instead, add tests
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 21 17:39:34 PDT 2012
Adam Barth <abarth at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 86916: garden-o-matic should not fetch from debug bots if it also knows
about the release bots
https://bugs.webkit.org/show_bug.cgi?id=86916
Attachment 143146: post a block of json instead, add tests
https://bugs.webkit.org/attachment.cgi?id=143146&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143146&action=review
Looks great. One nit below.
>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/script
s/checkout.js:100
> + net.post(config.kLocalServerURL + '/rebaselineall',
JSON.stringify(tests), function() { callback() });
function() { callback() } <--- You can just pass callback directly without
needing to create a thunk.
More information about the webkit-reviews
mailing list