[webkit-reviews] review denied: [Bug 87020] run-webkit-tests fails when svn is not installed : [Attachment 143033] Adds try/except guard around the svn call

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Lauro Moura Maranhao Neto
<lauro.neto at openbossa.org>'s request for review:
Bug 87020: run-webkit-tests fails when svn is not installed
https://bugs.webkit.org/show_bug.cgi?id=87020

Attachment 143033: Adds try/except guard around the svn call
https://bugs.webkit.org/attachment.cgi?id=143033&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143033&action=review


> Tools/Scripts/webkitpy/common/checkout/scm/svn.py:97
> +	   try:
> +	       exit_code = Executive().run_command(svn_info_args, cwd=path,
return_exit_code=True)
> +	       return (exit_code == 0)
> +	   except OSError:
> +	       return False

We need a test for this. r- due to the lack of a test.