[webkit-reviews] review granted: [Bug 86608] Add seamless layout code (and pass all the remaining seamless tests) : [Attachment 143128] Fixed per Ojan's review

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 21 16:32:49 PDT 2012


Ojan Vafai <ojan at chromium.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 86608: Add seamless layout code (and pass all the remaining seamless tests)
https://bugs.webkit.org/show_bug.cgi?id=86608

Attachment 143128: Fixed per Ojan's review
https://bugs.webkit.org/attachment.cgi?id=143128&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143128&action=review


> Source/WebCore/rendering/RenderIFrame.cpp:214
>      m_overflow.clear();
>      addVisualEffectOverflow();

Side comment: I'm not sure what overflow iframes can ever have. This code is
suspicious to me. Not that it should affect seamless in any way.


More information about the webkit-reviews mailing list