[webkit-reviews] review granted: [Bug 85579] IndexedDB: Fire error when there are problems opening a DB : [Attachment 143124] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 21 16:15:34 PDT 2012


Tony Chang <tony at chromium.org> has granted David Grogan
<dgrogan at chromium.org>'s request for review:
Bug 85579: IndexedDB: Fire error when there are problems opening a DB
https://bugs.webkit.org/show_bug.cgi?id=85579

Attachment 143124: Patch
https://bugs.webkit.org/attachment.cgi?id=143124&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143124&action=review


> Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp:100
> +	   backend.clear();

Nit: This shouldn't be necessary since backend is a RefPtr.

> Source/WebKit/chromium/tests/IDBAbortOnCorruptTest.cpp:40
> + public:

Nit: No space before public:.


More information about the webkit-reviews mailing list