[webkit-reviews] review granted: [Bug 83828] There are no shared worker filesystem tests : [Attachment 138388] Patch

Mon May 21 15:42:46 PDT 2012

David Levin <levin at chromium.org> has granted Eric U. <ericu at chromium.org>'s
request for review:
Bug 83828: There are no shared worker filesystem tests
https://bugs.webkit.org/show_bug.cgi?id=83828

Attachment 138388: Patch
https://bugs.webkit.org/attachment.cgi?id=138388&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=138388&action=review

> LayoutTests/fast/filesystem/workers/file-writer-events-shared.html:1
> +<!DOCTYPE HTML>

Personally I would prefer -shared-work instead of just -shared (because I can't
figure out what -shared means immediately when I see it like this.).

But I'm not so adamant that I think you must do this before checking in.

Consider this a "If it isn't too much trouble, it sure would be nice if..."