[webkit-reviews] review granted: [Bug 87046] [chromium] Port chromium compositor to use WebFilterOperation(s) : [Attachment 143103] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 87046: [chromium] Port chromium compositor to use WebFilterOperation(s)
https://bugs.webkit.org/show_bug.cgi?id=87046

Attachment 143103: Patch
https://bugs.webkit.org/attachment.cgi?id=143103&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=143103&action=review


R=me.  This is a huge patch, but really straightforward.  How are you handling
the Chromium side of this?

> Source/WebCore/platform/graphics/chromium/LayerChromium.cpp:327
> +    if (!backgroundFilters.isEmpty())
> +	   CCLayerTreeHost::setNeedsFilterContext(true);

Ack, nice catch.

> Source/WebCore/platform/graphics/chromium/LayerChromium.h:57
> +

nit: needless whitespace