[webkit-reviews] review granted: [Bug 85579] IndexedDB: Fire error when there are problems opening a DB : [Attachment 143088] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted David Grogan
<dgrogan at chromium.org>'s request for review:
Bug 85579: IndexedDB: Fire error when there are problems opening a DB
https://bugs.webkit.org/show_bug.cgi?id=85579

Attachment 143088: Patch
https://bugs.webkit.org/attachment.cgi?id=143088&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143088&action=review


> Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.h:55
> +	   bool success = false;
> +	   IDBDatabaseBackendImpl* backend = new IDBDatabaseBackendImpl(name,
database, coordinator, factory, uniqueIdentifier, success);
> +	   if (!success) {
> +	     delete backend;
> +	     return 0;
> +	   }

Using an out param for success in a constructor is weird.  Can we just call
openInternal here after the object is constructed?