[webkit-reviews] review denied: [Bug 87044] [Qt][WK2] EventSenderProxy::keyDown doesn't use the helper functions to send events : [Attachment 143093] Patch

[bugzilla-daemon at webkit.org]

Alexis Menard (darktears) <alexis.menard at openbossa.org> has denied Hugo Parente
Lima <hugo.lima at openbossa.org>'s request for review:
Bug 87044: [Qt][WK2] EventSenderProxy::keyDown doesn't use the helper functions
to send events
https://bugs.webkit.org/show_bug.cgi?id=87044

Attachment 143093: Patch
https://bugs.webkit.org/attachment.cgi?id=143093&action=review

------- Additional Comments from Alexis Menard (darktears)
<alexis.menard at openbossa.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143093&action=review


The #ifdef cleanup needs to go in a separate patch. He has nothing to do with
the main content of the patch (especially that it is in a different file).

> Tools/WebKitTestRunner/qt/EventSenderProxyQt.cpp:242
> +    QEvent* pressEvent = new QKeyEvent(QEvent::KeyPress, code, modifiers,
keyText);

nitpick: Why modifying QKeyEvent to QEvent? Keep it specialized.