[webkit-reviews] review denied: [Bug 87036] REGRESSION(88297) Tap shadow is down and to the right on the chrome web store : [Attachment 143072] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 87036: REGRESSION(88297) Tap shadow is down and to the right on the chrome
web store
https://bugs.webkit.org/show_bug.cgi?id=87036

Attachment 143072: Patch
https://bugs.webkit.org/attachment.cgi?id=143072&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
To test this, you'll need to use something like getClientRects:
https://developer.mozilla.org/en/DOM/element.getClientRects

You'll need an inline (aka, span) which is split by a block to cause a
continuation.  That continuation itself will need to be a block, which is not
immediately clear to me what cases that is.

Presumably this will work:

<span>foo<div>bar</div>baz</span>

The code was wrong before because it was adding the box (in this case "div")'s
size instead of it's location!	Which is just wrong.

You might have more luck with a more controlled example like this:

<span><img style="width: 50px; height: 50px"><div style="width: 75px; height:
200px "></div><img style="width: 50px; height: 50px"></span>

Which would allow you to better predict the sizes.  Warning: css line-height
and the line decent below the <img> tag will effect the total height of the
span rects, so they may be 4-8px larger than what you expect.

It's also possible that getClientRects doesn't use absoluteRects() (we have
several similarly named rect functions) but I think it does.