[webkit-reviews] review granted: [Bug 86925] [GTK] REGRESSION(r116135): Keys that confirm composition trigger a default action : [Attachment 142873] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 86925: [GTK] REGRESSION(r116135): Keys that confirm composition trigger a
default action
https://bugs.webkit.org/show_bug.cgi?id=86925

Attachment 142873: Patch
https://bugs.webkit.org/attachment.cgi?id=142873&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142873&action=review


Thanks =)

> Source/WebCore/ChangeLog:13
> +	   * platform/gtk/CompositionResults.h: Instead of holding composition
results, just hold
> +	   hold a flag describing whether or not this event had results.

too much hold

> Source/WebKit/gtk/WebCoreSupport/WebViewInputMethodFilter.cpp:63
> +    PlatformKeyboardEvent platformEvent(event,
CompositionResults(CompositionResults::WillSendCompositionResultsSoon));

Nice trick to make the code more readable =)