[webkit-reviews] review granted: [Bug 86649] isStartOfDocument and isEndOfDocument are poorly named : [Attachment 143050] Put back the missing changes

[bugzilla-daemon at webkit.org]

Levi Weintraub <leviw at chromium.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 86649: isStartOfDocument and isEndOfDocument are poorly named
https://bugs.webkit.org/show_bug.cgi?id=86649

Attachment 143050: Put back the missing changes
https://bugs.webkit.org/attachment.cgi?id=143050&action=review

------- Additional Comments from Levi Weintraub <leviw at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143050&action=review


>> Source/WebCore/ChangeLog:8
>> +	    isEndOfDocument to isEndOfEditableOrNonEditableContent because
that's what this function checks.
> 
> I believe you're missing the word "Changed" at the beginning :)

Make this a sentence.

>>> Source/WebCore/editing/visible_units.cpp:1400
>>> +bool isEndOfEditableOrNonEditableContent(const VisiblePosition &p)
>> 
>> This is still a pretty poor name. How about isAtEditableBoundary or even
isAtEndOfEditableBoundary?
> 
> isAtEditableBoundary is inaccurate. isAtEndOfEditableBoundary doesn't make
sense because an editing boundary is a point in DOM and a point/position
doesn't have a start/end.

I'm not in love with this name, but it's at least accurate in what it portrays
:)