[webkit-reviews] review denied: [Bug 87032] Restore WebGL's framebuffer binding after DrawingBuffer's prepareBackBuffer() : [Attachment 143066] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Zhenyao Mo <zmo at google.com>'s
request for review:
Bug 87032: Restore WebGL's framebuffer binding after DrawingBuffer's
prepareBackBuffer()
https://bugs.webkit.org/show_bug.cgi?id=87032

Attachment 143066: Patch
https://bugs.webkit.org/attachment.cgi?id=143066&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143066&action=review


> Source/WebCore/platform/graphics/chromium/DrawingBufferChromium.cpp:138
>      if (multisample())
>	   bind();
> +
> +    restoreFramebufferBinding();

Something here is clearly wrong.  line 136 is binding m_multisampleFBO ?
m_multisampleFBO : m_fbo.  Line 138 is binding m_framebufferBinding.  We should
make up our mind and just bind one.