[webkit-reviews] review granted: [Bug 85555] Enable SUBPIXEL_LAYOUT feature flag on Chromium : [Attachment 142615] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 21 11:26:58 PDT 2012


Eric Seidel <eric at webkit.org> has granted Levi Weintraub <leviw at chromium.org>'s
request for review:
Bug 85555: Enable SUBPIXEL_LAYOUT feature flag on Chromium
https://bugs.webkit.org/show_bug.cgi?id=85555

Attachment 142615: Patch
https://bugs.webkit.org/attachment.cgi?id=142615&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142615&action=review


OK.

> LayoutTests/fast/dom/Window/webkitConvertPoint.html:151
> +	       if (hasSubpixelSupport) {
> +		   runTest("Test 1",  "test1",	8, 13, 13, 53);
> +		   runTest("Test 2",  "test2",	8, 51, 13, 91);
> +		   runTest("Test 3",  "test3",	8, 85, 13, 125);
> +		   runTest("Test 4",  "test4",	8, 119, 13, 159);
> +		   runTest("Test 5",  "test5",	28, 153, 33, 193);
> +		   runTest("Test 6",  "test6",	28, 187, 33, 227);
> +		   runTest("Test 7",  "test7",	8, 239, 13, 279);
> +		   runTest("Test 8",  "test8",	8, 273, 13, 313);
> +		   runTest("Test 9",  "test9",	28, 291, 33, 331);
> +		   runTest("Test 10", "test10", 28, 309, 33, 349);
> +		   runTest("Test 11", "test11", 158, 355, 174, 373);
> +		   runTest("Test 12", "test12", 168, 428, 184, 446);
> +		   runTest("Test 13", "test13", 28, 487, 33, 527);
> +	       } else {

This seems a pain to maintain.


More information about the webkit-reviews mailing list