[webkit-reviews] review granted: [Bug 86931] LayoutTests: fast/js/resources/js-test-pre.js - shouldBeEqualToString fails on " : [Attachment 143058] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Joshua Bell <jsbell at chromium.org>'s
request for review:
Bug 86931: LayoutTests: fast/js/resources/js-test-pre.js -
shouldBeEqualToString fails on "
https://bugs.webkit.org/show_bug.cgi?id=86931

Attachment 143058: Patch
https://bugs.webkit.org/attachment.cgi?id=143058&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143058&action=review


> LayoutTests/fast/js/resources/js-test-pre.js:261
> +  var unevaledString = JSON.stringify(b);

On the one hand, this is simpler, on the other it means that if you're
explicitly testing that you get a string and not and object that stringifies to
the same thing, then this won't work. 

Can we add a typeof b == 'string' check?