[webkit-reviews] review requested: [Bug 86065] FractionalLayoutUnit minor math bugs : [Attachment 143053] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 21 10:05:32 PDT 2012


Allan Sandfeld Jensen <allan.jensen at nokia.com> has asked  for review:
Bug 86065: FractionalLayoutUnit minor math bugs
https://bugs.webkit.org/show_bug.cgi?id=86065

Attachment 143053: Patch
https://bugs.webkit.org/attachment.cgi?id=143053&action=review

------- Additional Comments from Allan Sandfeld Jensen <allan.jensen at nokia.com>
Remove changes to a*b/c expressions. Darin is right, extra parenthesises are
redundant.

Removed the explicit .toFloat() casts as well, and instead implemented a full
set of operator X= operators. I have verified that this ensures the operations
are performed in the correct types (at least for the combinations of
FractionalLayoutUnit, int and float).


More information about the webkit-reviews mailing list