[webkit-reviews] review denied: [Bug 86844] Web Inspector: "Deactivate All Breapoints" should visually get reflected in Breakpoints pane. : [Attachment 142976] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied sam <dsam2912 at gmail.com>'s
request for review:
Bug 86844: Web Inspector: "Deactivate All Breapoints" should visually get
reflected in Breakpoints pane.
https://bugs.webkit.org/show_bug.cgi?id=86844

Attachment 142976: Patch
https://bugs.webkit.org/attachment.cgi?id=142976&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142976&action=review


> Source/WebCore/inspector/front-end/BreakpointManager.js:141
> +    updateActiveStateForBreakpoints: function()

Breakpoint manager does not have to be involved, just inline it.

> Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js:48
> +    this.breakpointActiveState = true;

You should use WebInspector.debuggerModel.breakpointsActive() so that you don't
need to keep them in sync.

> Source/WebCore/inspector/front-end/BreakpointsSidebarPane.js:177
> +	  
contextMenu.appendItem(breakpointActivationTitle,this._breakpointManager.update
ActiveStateForBreakpoints.bind(this._breakpointManager)); 

" " before "," please.