[webkit-reviews] review granted: [Bug 86948] CSS: Move duplicate property elimination to parser. : [Attachment 143040] Patch v2

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <kling at webkit.org>'s
request for review:
Bug 86948: CSS: Move duplicate property elimination to parser.
https://bugs.webkit.org/show_bug.cgi?id=86948

Attachment 143040: Patch v2
https://bugs.webkit.org/attachment.cgi?id=143040&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=143040&action=review


> Source/WebCore/css/CSSParser.cpp:1113
> +template<unsigned fixedSize>
> +class FixedBitArray

I would use it if it was in WTF.

>> Source/WebCore/css/CSSParser.cpp:1114
>> +{
> 
> This { should be at the end of the previous line  [whitespace/braces] [4]

By Toutatis, the bot is right!

> Source/WebCore/css/CSSParser.cpp:1121
> +    void quickSet(unsigned index)

The quickFoo naming makes little sense with this type as there are no slow
versions. For compatibility I guess?

> Source/WebCore/css/CSSParser.cpp:1124
> +	   m_data[index / 8] |= 1 << (index & 7);

It would look more consistent if you used >> instead of / (here and elsewhere).