[webkit-reviews] review granted: [Bug 87022] Web Inspector: switch buildDominatedNodes function to front-end calculated _dominatorsTree : [Attachment 143043] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 21 08:52:09 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 87022: Web Inspector: switch buildDominatedNodes function to front-end
calculated _dominatorsTree
https://bugs.webkit.org/show_bug.cgi?id=87022

Attachment 143043: Patch
https://bugs.webkit.org/attachment.cgi?id=143043&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143043&action=review


> Source/WebCore/inspector/front-end/HeapSnapshot.js:-722
> -	   if (this._dominatorOffset !== -1) // For tests where we may not have
dominator field.

Please make sure that it doesn't break tests.


More information about the webkit-reviews mailing list