[webkit-reviews] review granted: [Bug 87009] Web Inspector: introduce a helper for HeapSnapshot post-processing tests. : [Attachment 143030] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 87009: Web Inspector: introduce a helper for HeapSnapshot post-processing
tests.
https://bugs.webkit.org/show_bug.cgi?id=87009

Attachment 143030: Patch
https://bugs.webkit.org/attachment.cgi?id=143030&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=143030&action=review


> LayoutTests/inspector/profiler/heap-snapshot-test.js:385
> +    this._size = size || 0;

_size => _selfSize?

> LayoutTests/inspector/profiler/heap-snapshot-test.js:434
> +	   rawSnapshot.nodes.push(this._ordinal * 2 + 1);    // id has to be
odd for the consistency with backend implementation.

Please state explicitly that we differentiate between JS nodes and DOM groups
by the oddity of the id.

> LayoutTests/inspector/profiler/heap-snapshot-test.js:447
> +    this._node = node;

_node => _targetNode

> LayoutTests/inspector/profiler/heap-snapshot.html:135
> +	    debuggerNode.linkNode(debuggerOwnedNode,
InspectorTest.HeapEdge.Type.element);

Wrong alignment.