[webkit-reviews] review granted: [Bug 86991] REGRESSION r110315: Event handler throws TypeError for an input element with name="arguments" : [Attachment 142950] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 86991: REGRESSION r110315: Event handler throws TypeError for an input
element with name="arguments"
https://bugs.webkit.org/show_bug.cgi?id=86991

Attachment 142950: Patch
https://bugs.webkit.org/attachment.cgi?id=142950&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142950&action=review


> Source/WebCore/bindings/v8/V8LazyEventListener.cpp:143
>      String code = "(function() {" \
> -	   "with (arguments[2]) {" \
> -	   "with (arguments[1]) {" \
> -	   "with (arguments[0]) {";
> +	   "with (this.ownerDocument ? this.ownerDocument : {}) {" \
> +	   "with (this.form ? this.form : {}) {" \
> +	   "with (this) {";

This code is so ridiculous.