[webkit-reviews] review requested: [Bug 82034] [Forms] Move numeric related methods in HTMLInputElement class to another place : [Attachment 142942] Patch 8

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun May 20 22:15:25 PDT 2012


yosin at chromium.org has asked  for review:
Bug 82034: [Forms] Move numeric related methods in HTMLInputElement class to
another place
https://bugs.webkit.org/show_bug.cgi?id=82034

Attachment 142942: Patch 8
https://bugs.webkit.org/attachment.cgi?id=142942&action=review

------- Additional Comments from yosin at chromium.org
* Build with ENABLE_INPUT_TYPE_*=1
* Build with CR-Linux w/ clang
* Introduce StepValueShouldBe enum to combine two Boolean values. We need three
value rather than four value.
** There is no combination parsed and scaled should be integer.

Could you review again?
Thanks in advance.


More information about the webkit-reviews mailing list