[webkit-reviews] review granted: [Bug 86923] [Chromium-Android] Run DumpRenderTree as an apk (python part) : [Attachment 142822] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun May 20 20:54:34 PDT 2012
Adam Barth <abarth at webkit.org> has granted Xianzhu Wang
<wangxianzhu at chromium.org>'s request for review:
Bug 86923: [Chromium-Android] Run DumpRenderTree as an apk (python part)
https://bugs.webkit.org/show_bug.cgi?id=86923
Attachment 142822: patch
https://bugs.webkit.org/attachment.cgi?id=142822&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142822&action=review
Ok. This is mostly a rubber stamp, but this looks plausible.
> Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:481
> + if seconds == DRT_START_STOP_TIMEOUT_SECS:
Should we use >= instead of == ?
More information about the webkit-reviews
mailing list