[webkit-reviews] review granted: [Bug 86922] [Chromium-Android] Run DumpRenderTree as an apk (C++ and gyp part) : [Attachment 142821] patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Xianzhu Wang
<wangxianzhu at chromium.org>'s request for review:
Bug 86922: [Chromium-Android] Run DumpRenderTree as an apk (C++ and gyp part)
https://bugs.webkit.org/show_bug.cgi?id=86922

Attachment 142821: patch
https://bugs.webkit.org/attachment.cgi?id=142821&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=142821&action=review


Looks ok.

> Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:83
> +		   'ImageDiff',
> +		   'TestNetscapePlugIn',
> +		   'copy_TestNetscapePlugIn',

Why did you move them to here?	It looks a unnecessary change.

> Tools/DumpRenderTree/chromium/TestShellAndroid.cpp:45
> +const char optionInFifo[] = "--in-fifo=";
> +const char optionOutFifo[] = "--out-fifo=";

should be optionInFIFO and optionOutFIFO.
http://www.webkit.org/coding/coding-style.html#names-basic

> Tools/DumpRenderTree/chromium/TestShellAndroid.cpp:87
> +    const char* inFifo = 0;
> +    const char* outFifo = 0;

should be inFIFO and outFIFO.