[webkit-reviews] review denied: [Bug 86948] CSS: Move duplicate property elimination to parser. : [Attachment 142881] Proposed patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has denied Andreas Kling <kling at webkit.org>'s
request for review:
Bug 86948: CSS: Move duplicate property elimination to parser.
https://bugs.webkit.org/show_bug.cgi?id=86948

Attachment 142881: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=142881&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=142881&action=review


Nice, except...

> Source/WebCore/css/CSSParser.cpp:1113
> +template<unsigned size>
> +class PrimitiveSet {

I don't quite understand the purpose of this type. Can't it be replaced with a
BitVector of size numCSSProperties? The only benefit I see is that you avoid
zeroing the memory. However zeroing 38 bytes is not that costly. With this the
lookup and setting is slower (two reads/writes). Valgrind and pals are also
likely to go crazy.